Problem with transparent material

[Andy90]

According to the discord talk here the bug report. If you take the model i sended you last time and drag it into the scene you can see some "circle" appearing within the windos. It also happens in the scene editor. Within the model viewer everything works fine.

 

 

[Josh]

Confirmed, I am investigating...

[Josh]

There is something strange happening. It doesn't even have to be transparent. It has something to do with the diffuse PBR reflection and the metal/roughness map I think...

[Josh]

There appears to be some small error with very low values near zero in the linear to srgb conversion...

[Josh]

Before modifying the sRGB / linear equations I think we should try storing cubemaps in linear color space. I was already planning this, but wanted to talk about it this weekend with you guys and explain the reasons for it, before making any further changes. Let's see what the result of that is after we try it, as it may eliminate this problem.

[Josh]

It's definitely being caused by the final linear to sRGB conversion. If we leave everything in linear color space it looks fine:

Curved lines are visible after the linear to sRGB conversion.

[Josh]

If I ignore values below a threshold the lines go away:

vec3 linearTosRGB(vec3 color, float invgamma)
{
    const float lower = 0.001f;
    if (color.r > lower && color.r < 1.0f) color.r = pow(color.r, invgamma);
    if (color.g > lower && color.g < 1.0f) color.g = pow(color.g, invgamma);
    if (color.b > lower && color.b < 1.0f) color.b = pow(color.b, invgamma);
    return color;
}

 

[Andy90]

sound nice